[PATCH] D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D

[Digger via Phabricator via llvm-commits]

DiggerLin marked an inline comment as done.
DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1383
                          SectionAddr + Start + VMAAdjustment);
-
-      outs() << SymbolName << ":\n";
+      if (Obj->isXCOFF()) {
+        printXCOFFSymbolDescription(Symbols[SI], SymbolName);
----------------
daltenty wrote:
> Shouldn't this behaviour be option gated under an XCOFF specific option? As is this is going to result in output incompatible with binutils objdump on AIX, which could break tools.
when dissemble the xcoff object file, we change the label to symbol index+ symbol name + storage mapping class, it is not a new option. I think it is different with the  with binutils objdump on AIX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973