[PATCH] D74438: [mlir] Allow adding extra class declarations to interfaces.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 10:06:12 PST 2020


rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/include/mlir/IR/OpBase.td:1484
+  // An optional code block containing extra declarations to place in the
+  // interface declaration.
+  code extraClassDeclaration = "";
----------------
jpienaar wrote:
> So these would be placed alongside methods ?
Yes. For the side effect interfaces I want to have several template methods available, which is something you can't do with "interface methods".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74438/new/

https://reviews.llvm.org/D74438





More information about the llvm-commits mailing list