[PATCH] D74448: [scudo][standalone] Allow setting release to OS

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added a comment.

I think this works.
Once the comment raised is addressed, this can go in like this, and my next step would be to change the parameters to a Config class like it's done in other places and like pcc@ did for the new sizeclassmap.



================
Comment at: compiler-rt/lib/scudo/standalone/primary64.h:96
+    if (ReleaseToOsInterval < 0) {
+      ReleaseToOsInterval = DefaultReleaseToOsIntervalMs;
+    }
----------------
With this block, I don't think we can ever set a negative interval (eg: never release) via the options string if the default is not negative.
A possible solution could be to have a specific "not-specified" value for the parameter default maybe that would entice a fallback to the default value (an enum/define of INT32_MAX maybe or something negative)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74448/new/

https://reviews.llvm.org/D74448