[PATCH] D74465: [Statepoint] Remove redundant clear of call target on register

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 08:51:50 PST 2020


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.  Looking through the code, it really looks like the null callee value isn't even really being used by the lowering.  It's an operand on the MachineInst and thus gets emitted, but in the nop-padding case it doesn't appear to make into the MC Stream.  We could, arguably should, restructure to remove it.  Your patch appears to be correct, and a step in the right direction, so go for it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74465/new/

https://reviews.llvm.org/D74465





More information about the llvm-commits mailing list