[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

Wed Feb 12 07:27:22 PST 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/attribute.test:6
+
+#CHECK-OBJ: Tag: 4
+#CHECK-OBJ-NEXT: Value: 16
----------------
Add a space between the '#' and the "CHECK" here and below.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/attribute.test:36
+    Type: SHT_RISCV_ATTRIBUTES
+    Content: 4132000000726973637600012800000004100572763332693270305F6D3270305F613270305F6332703000060008020A000C00
----------------
When I said "add support to yaml2obj", I meant adding something to yaml2obj that makes these things a bit more section- specific, a bit like the relocation sections. That way, the YAML blob is not as opaque as this. I'd prefer an assembly test over something opaque.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023