[PATCH] D72885: Add Query API for llvm.assume holding attributes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/KnowledgeRetention.h:82
+  ~SetPreserveAllScope();
+};
+
----------------
This is not needed anymore, or is it? (I hope we can replace it somehow if it is.)


================
Comment at: llvm/lib/Transforms/Utils/KnowledgeRetention.cpp:65
 /// attribute with binary search. However finding the right WasOn needs to be
 /// done via linear search because values can get remplaced.
 bool isLowerOpBundle(const OperandBundleDef &LHS, const OperandBundleDef &RHS) {
----------------
Typo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72885/new/

https://reviews.llvm.org/D72885