[PATCH] D68899: llvm/cmake/config.guess: add support for riscv32 and riscv64

[Gokturk Yuksek via Phabricator via llvm-commits]

gokturk added a comment.

In D68899#1872251 <https://reviews.llvm.org/D68899#1872251>, @luismarques wrote:

> In D68899#1872213 <https://reviews.llvm.org/D68899#1872213>, @gokturk wrote:
>
> > The current config.guess is GPL-2 or later. The upstream config.guess is GPL-3. I was under the impression that LLVM upstream wanted to maintain a GPL-2 license. So I wrote my own version.
>
>
> I also thought that might be a problem, but there are two more `config.guess` files in the monorepo, and one of them is GPL-3 (`polly/lib/External/isl/config.guess`), but maybe that's not considered core to LLVM enough to matter? I'm not sure to what extent a configure script is considered to affect the general LLVM license...


I couldn't find anything in the comment messages regarding a license issue. I do see that Haiku support was added just like this (https://github.com/llvm/llvm-project/commit/9590c532b892743040b7a3ea8a8308098e1aff1e#diff-becde2e85ab9b9a6321925ea7aec6815), instead of simply having config.guess updated from its upstream. There ought to be a reason why nobody updated it since 2011. Regardless, this patch sidesteps the license question and should be safe to apply.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68899/new/

https://reviews.llvm.org/D68899