[PATCH] D74479: [llvm-readobj] - Report a warning when an unexpected DT_SYMENT tag value is met.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 07:37:03 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2068
+            createError(
+                "DT_SYMENT value contains the unexpected symbol size of 0x" +
+                Twine::utohexstr(Val)),
----------------
I think this would be better: "DT_SYMENT value of 0x123 is not the size of a symbol (0x456)".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74479/new/

https://reviews.llvm.org/D74479





More information about the llvm-commits mailing list