[PATCH] D74477: [llvm-ar] Simplify Windows comparePaths NFCI

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

In D74477#1872033 <https://reviews.llvm.org/D74477#1872033>, @grimar wrote:

> > This is not necessary for CompareStringOrdinal and could possibly even cause problems.
>
> Perhaps I am not a good person to review this patch. Have a question though: by "cause problems" do you know something that can be wrapped into a test case?


No, I don't know of an example problem and there might not be a case where a problem could occur. The behaviour of widenPath is dependent on the input length. So if there is a possibility that two strings of different length can be "equal" according to CompareStringOrdinal, then widenPath could cause a problem. What makes the situation a little more likely to be problematic, is that the current implementation of widenPath bases it's decisions on the length of the UTF-8 input.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74477/new/

https://reviews.llvm.org/D74477