[PATCH] D74481: [Debuginfo][NFC] Create common error handlers for DWARFContext.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 05:45:50 PST 2020


avl created this revision.
avl added reviewers: jhenderson, dblaikie, probinson, aprantl, JDevlieghere.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
avl added a project: debug-info.

this review is extracted from D74308 <https://reviews.llvm.org/D74308>.

It creates two error handlers which allow to redefine error
reporting routine and should be used for all places
where errors are reported:

  std::function<void(Error)> RecoverableErrorHandler = defaultErrorHandler;
  std::function<void(Error)> WarningHandler = defaultWarningHandler;

It also creates accessors to above handlers which should be used to
report errors.

  function_ref<void(Error)> getRecoverableErrorHandler() {
    return RecoverableErrorHandler;
  }
  
  function_ref<void(Error)> getWarningHandler() { return WarningHandler; }

It patches all error reporting places inside DWARFContext and DWARLinker.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74481

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74481.244146.patch
Type: text/x-patch
Size: 14759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200212/8afdef1b/attachment.bin>


More information about the llvm-commits mailing list