[PATCH] D64827: [Xtensa 2/10] Add Xtensa ELF definitions.

[Andrei Safronov via Phabricator via llvm-commits]

andreisfr added inline comments.


================
Comment at: llvm/test/Object/obj2yaml.test:734
 
+# RUN: obj2yaml %p/Inputs/trivial-object-test.elf-xtensa | FileCheck %s --check-prefix ELF-XTENSA
+
----------------
jhenderson wrote:
> Rather than adding a pre-canned binary, use yaml2obj to generate a file.
You suggest to create separate obj2yaml test for Xtensa? 
Or add Xtensa ELF header yaml description in current file? I'm bother that  there is already X86 ELF yaml description in this file, so yaml2obj could produce wrong result while processing obj2yaml.test. As I'm understand that is a reason why tests foir all other architectures in this file use pre-canned binaries.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64827/new/

https://reviews.llvm.org/D64827