[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

Wed Feb 12 03:00:56 PST 2020

Chirag added a comment.

In D74470#1871645 <https://reviews.llvm.org/D74470#1871645>, @djtodoro wrote:

> Does this support the old metadata? We should have a test for the old metadata as well (e.g. `flags: DIFlagBigEndian`).
>
> As we discussed on D73261 <https://reviews.llvm.org/D73261>, we might have to move a few flags from `DIFlags` into `DISPFlags`.

There is no bitcode testcase available for DIFlagBigEndian in llvm test suite, the current patch adds one bitcode test using DIBTFlagBigEndian/DIBTFlagLittleEndian. 
The old metadata related bc files needs to be updated(if it uses DIFlagBigEndian) by DIBTFlag

Also for backward compatibility, the values of the flags can be kept the same.
 <- HANDLE_DI_FLAG((1 << 27), BigEndian)
 <- HANDLE_DI_FLAG((1 << 28), LittleEndian)

+ HANDLE_DIBT_FLAG((1 << 27), BigEndian) instead of 1
+ HANDLE_DIBT_FLAG((1 << 28), LittleEndian) instead of 2

This will keep the old bitcode format compatible, does this something you think might be usefull?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74470/new/

https://reviews.llvm.org/D74470