[PATCH] D74322: GlobalISel: Extend narrowing to G_ASHR
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 12 01:47:56 PST 2020
foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.
In D74322#1871587 <https://reviews.llvm.org/D74322#1871587>, @foad wrote:
> I guess it's up to you, but given that we already have a constant folding MIR builder it seems silly to write (and test and review) extra code to handle cases that it could handle for you.
I was wrong. ConstantFoldingMIRBuilder only handles genuine constant folding like 3+4. It doesn't simplify degenerate cases like adding or shifting by 0.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74322/new/
https://reviews.llvm.org/D74322
More information about the llvm-commits
mailing list