[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 01:38:51 PST 2020


jhenderson added a comment.

I don't really have a strong opinion either way. By strict style rules, "ELF" is an acronym, so should be all upper-case. In regular text, I'd expect it to be ELF everywhere too. On the other hand, as pointed out, "elf" is the bfd naming style.

For WASM, I recall there being some discussion to standardise on a particular format, and it would make sense if we can be consistent across all file formats. Perhaps @sbc100 could bring his insights from that side over.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74433/new/

https://reviews.llvm.org/D74433





More information about the llvm-commits mailing list