[PATCH] D74402: [DebugInfo][test][NFC] Remove case numbers

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 00:52:47 PST 2020


jhenderson added a comment.

In D74402#1870045 <https://reviews.llvm.org/D74402#1870045>, @dblaikie wrote:

> Looks good (should these tests be testing the diagnostic text of the recoverable errors, in addition to testing the fact that they are recovered from/dumped?)


They do - see the block at the bottom of the test with the ALL/OTHER prefixes. They aren't inline with the body, as I don't think the exact interleaving of the output is necessarily that important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74402/new/

https://reviews.llvm.org/D74402





More information about the llvm-commits mailing list