[PATCH] D74405: [llvm-readobj] - Deprecate the unwrapOrError helper.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 00:15:59 PST 2020


grimar planned changes to this revision.
grimar added a comment.

In D74405#1869755 <https://reviews.llvm.org/D74405#1869755>, @jhenderson wrote:

> Why not just get rid of it, and update the call sites?


Well... because I see 153 of them :) I think we should and I do not mind to care about at least some of them, but given the previous my experience my guess is
(I did not yet check though) that many of them are uncovered by tests. Writing tests for that amount of places might take a significant time.

Let me try to investigate it more though. May be it is not that bad how it looks like to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74405/new/

https://reviews.llvm.org/D74405





More information about the llvm-commits mailing list