[PATCH] D73542: [LLD][ELF][ARM] Do not substitute BL/BLX for non STT_FUNC symbols.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

My impression is that it's an easy enough bug to make with hand-written assembly. I don't know what the probability of a false positive is vs. actual issues being caught.

>From the perspective of someone who works on a huge codebase that uses LLD to link for ARM, I'd much prefer a link-time warning (and we use `--fatal-warnings` so it'll be an error) to a runtime crash. That has to be balanced against the annoyance from false positives, of course, but I don't know what the real-world probability of hitting a false positive is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73542/new/

https://reviews.llvm.org/D73542