[PATCH] D74439: [mlir][SideEffects] Define a set of interfaces and traits for defining side effects

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added a comment.

Just very quick skim, but could you add tests here already?



================
Comment at: mlir/include/mlir/IR/SideEffects.td:1
+//===- SideEffects.td - Side Effect interfaces -*- tablegen -*-------------===//
+//
----------------
Isn't the extra --- normally on the left? https://llvm.org/docs/CodingStandards.html#file-headers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74439/new/

https://reviews.llvm.org/D74439