[PATCH] D74391: [llvm-readelf] Match GNU readelf more more closely when dumping notes

[Alexander Richardson via Phabricator via llvm-commits]

arichardson marked an inline comment as done.
arichardson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5054
     } else if (!Descriptor.empty()) {
-      OS << "   description data:";
+      OS << "    Description data:";
       for (uint8_t B : Descriptor)
----------------
rupprecht wrote:
> I'm not able to reproduce this part. Using the example binary generated by llvm/test/tools/llvm-readobj/ELF/note-freebsd.s:
> 
> ```
> $ readelf --version
> GNU readelf (GNU Binutils) 2.34.50.20200211
> ...
> $ readelf -n /tmp/freebsd.o
> 
> Displaying notes found in: .note.foo
>   Owner                Data size        Description
>   FreeBSD              0x00000000       NT_THRMISC (thrmisc structure)
>   FreeBSD              0x00000000       NT_PROCSTAT_PROC (proc data)
> 
> Displaying notes found in: .note.bar
>   Owner                Data size        Description
>   FreeBSD              0x00000000       NT_PROCSTAT_FILES (files data)
> 
> Displaying notes found in: .note.baz
>   Owner                Data size        Description
>   FreeBSD              0x0000001c       Unknown note type: (0x00000003)
>    description data: 4c 6f 72 65 6d 20 69 70 73 75 6d 20 64 6f 6c 6f 72 20 73 69 74 20 61 6d 65 74 00 00
> ```
> 
> Are you comparing against readelf sources that have a local patch to capitalize description?
Interesting, I am using `GNU readelf (GNU Binutils) 2.32.51`. Will check if it's changed upstream since.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74391/new/

https://reviews.llvm.org/D74391