[PATCH] D74078: [Clang] When using SEH, create a impl instance for CrashRecoveryContext. NFCI.

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 14:13:36 PST 2020


aganea added a comment.

In D74078#1870669 <https://reviews.llvm.org/D74078#1870669>, @tra wrote:

> Tensorflow folks report that the `__try()` here does not compile on windows:
>  Any ideas what could be wrong?


Usage of /EHsc most likely. Does it work on the previous revision of the code? If that's the case, could ask them to move the `__try/__catch` block into a separate function like it used to be, see if that works for them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74078/new/

https://reviews.llvm.org/D74078





More information about the llvm-commits mailing list