[PATCH] D74256: [AIX] Change host detection to return correct 32/64-bit triple

Tue Feb 11 13:37:21 PST 2020

daltenty marked an inline comment as done.
daltenty added inline comments.

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:174
-    set(CMAKE_CXX_ARCHIVE_FINISH "<CMAKE_RANLIB> -X64 <TARGET>")
-  endif()
   # -fPIC does not enable the large code model for GCC on AIX but does for XL.
----------------
stevewan wrote:
> Is this change somewhat out of scope here and fits better in a separate patch?
The reason I'd included in this patch is it affects your ability to test this change. CMake won't set CMAKE_SIZEOF_VOID_P to the 64-bit case unless you have OBJECT_MODE=64 set, but these options override the OBJECT_MODE setting.

Maybe the best option is to split this patch and land this bit first.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74256/new/

https://reviews.llvm.org/D74256