[PATCH] D74441: [mlir][SideEffects] Replace the old SideEffects dialect interface with the newly added op interfaces/traits.
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 11 13:18:54 PST 2020
rriddle created this revision.
rriddle added reviewers: mehdi_amini, jpienaar.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.
The old interface was a temporary stopgap to allow for implementing simple LICM that took side effects of region operations into account. Now that MLIR has proper support for specifying memory effects, this interface can be deleted.
Depends On D74440 <https://reviews.llvm.org/D74440>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D74441
Files:
mlir/include/mlir/Dialect/AffineOps/AffineOps.td
mlir/include/mlir/Dialect/LoopOps/LoopOps.td
mlir/include/mlir/Transforms/SideEffectsInterface.h
mlir/lib/Dialect/AffineOps/AffineOps.cpp
mlir/lib/Dialect/LoopOps/LoopOps.cpp
mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
mlir/test/Transforms/loop-invariant-code-motion.mlir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74441.243973.patch
Type: text/x-patch
Size: 12316 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200211/05880b61/attachment.bin>
More information about the llvm-commits
mailing list