[PATCH] D74434: AMDGPU: Don't expand more special div cases in IR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 13:10:04 PST 2020


arsenm added a comment.

In D74434#1870551 <https://reviews.llvm.org/D74434#1870551>, @rampitec wrote:

> LGTM, but do not you want to handle it in the IR right away instead of TODO?


There are a lot of them to sort through, and I'm worried we don't have tests everywhere for all the special cases. Longer term, I would rather just eliminate the IR expansion altogether. In GlobalISel we can run MachineLICM on the legalized, pre-selected MIR which could be potentially avoid the need for this anyway


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74434/new/

https://reviews.llvm.org/D74434





More information about the llvm-commits mailing list