[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

Tue Feb 11 12:51:53 PST 2020

tstellar added a comment.

Any other commits before I commit this?

================
Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:33
+  if (NOT ARG_SOURCE_DIR)
+    set(ARG_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
+  endif()
----------------
delcypher wrote:
> @tstellar I'm not 100% sure about this but I think you probably want `${CMAKE_CURRENT_SOURCE_DIR}` quoted. If it's not then if it contains spaces I think you might make `ARG_SOURCE_DIR` a list. Then we you go to print it you'll probably end up with list separators (i.e. `;`) in the command you pass the the sphinx binary.
> 
> I've not tested this though so I could be wrong.
There are quotes used when setting variables above, so I went ahead and changed this to match.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72875/new/

https://reviews.llvm.org/D72875