[PATCH] D73579: [mlir] Add elementAttr to TypedArrayAttrBase.

[Abdurrahman Akkas via Phabricator via llvm-commits]

abeakkas updated this revision to Diff 243957.
abeakkas added a comment.

Added RECORD-LABEL to SomeTypedArrayAttr test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73579/new/

https://reviews.llvm.org/D73579

Files:
  mlir/include/mlir/IR/OpBase.td
  mlir/test/mlir-tblgen/op-attribute.td


Index: mlir/test/mlir-tblgen/op-attribute.td
===================================================================
--- mlir/test/mlir-tblgen/op-attribute.td
+++ mlir/test/mlir-tblgen/op-attribute.td
@@ -1,5 +1,6 @@
 // RUN: mlir-tblgen -gen-op-decls -I %S/../../include %s | FileCheck %s --check-prefix=DECL --dump-input-on-failure
 // RUN: mlir-tblgen -gen-op-defs -I %S/../../include %s | FileCheck %s --check-prefix=DEF --dump-input-on-failure
+// RUN: mlir-tblgen -print-records -I %S/../../include %s | FileCheck %s --check-prefix=RECORD --dump-input-on-failure
 
 include "mlir/IR/OpBase.td"
 
@@ -239,3 +240,12 @@
 // DEF:   return {{.*}} != nullptr
 
 // DEF: build(Builder *odsBuilder, OperationState &odsState, /*optional*/UnitAttr attr)
+
+
+// Test elementAttr field of TypedArrayAttr.
+// ---
+
+def SomeTypedArrayAttr : TypedArrayAttrBase<SomeAttr, "SomeAttr array">;
+
+// RECORD-LABEL: def SomeTypedArrayAttr
+// RECORD: Attr elementAttr = SomeAttr;
Index: mlir/include/mlir/IR/OpBase.td
===================================================================
--- mlir/include/mlir/IR/OpBase.td
+++ mlir/include/mlir/IR/OpBase.td
@@ -1101,6 +1101,8 @@
                           "; })">]>,
     description> {
   let constBuilderCall = "$_builder.getArrayAttr($0)";
+
+  Attr elementAttr = element;
 }
 
 def I32ArrayAttr : TypedArrayAttrBase<I32Attr,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73579.243957.patch
Type: text/x-patch
Size: 1362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200211/77803047/attachment.bin>