[PATCH] D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added a comment.

How difficult is it to support both the old-style "does not return a value" and the new terminator that does return a value?



================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:281
                 /*printEntryBlockArgs=*/false,
-                /*printBlockTerminators=*/false);
+                /*printBlockTerminators=*/printBlockTerminators);
 
----------------
The comment here doesn't seem necessary.


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:289
                   /*printEntryBlockArgs=*/false,
-                  /*printBlockTerminators=*/false);
+                  /*printBlockTerminators=*/printBlockTerminators);
   }
----------------
Likewise here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74174/new/

https://reviews.llvm.org/D74174