[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Yeah, we don't always do this perfectly (sometimes get lazy and add dumping/output support in the same patch, without standalone tests for the dumping) but it's a good practice to get into & helps separate patches out (yes, the dumping and output patches should be committed separately and should be tested when they're committed  - which means assembly or yaml based input for the dumping functionality first, then the codegen/output testing is done in terms of the dumping functionality already submitted/tested).



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:92-93
+      if (getVersion() >= 5)
+        return;
+      else
+        // Reached end of a ".debug_macinfo" section contribution.
----------------
Remove the else-after-return: https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086