[PATCH] D74404: [DebugInfo] Fix reading addresses in DWARFDebugAddr.

Tue Feb 11 08:57:23 PST 2020

dblaikie added inline comments.

================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_addr_rela.s:1-2
+# RUN: llvm-mc %s -filetype obj -triple x86_64-pc-linux -o %t.o
+# RUN: obj2yaml %t.o | FileCheck %s --check-prefix=YAML
+# RUN: llvm-dwarfdump -debug-addr %t.o | FileCheck %s
----------------
jhenderson wrote:
> dblaikie wrote:
> > jhenderson wrote:
> > > I'm not sure I entirely follow why you go through the dance you are doing here? Why not just write the YAML directly?
> > I think the asm/yaml checking isn't needed here (I guess it's an attempt to demonstrate that the values in the section are all zeros, and only by applying the relocation do we get the addend applied - but I don't think the test needs to demonstrate that the bytes are all zeros - the test should just verify that the address printed by dwarfdump includes the addend, however it got there)
> > 
> > So please remove the YAML testing & keep the dwarfdump testing.
> FWIW, it _might_ be better to use YAML as input directly, rather than needing to write assembly, but I'm happy to go with whichever is easier to read.
Ah, sure - yeah, I'm not strongly invested in assembly versus YAML. Dealer's choice.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74404/new/

https://reviews.llvm.org/D74404