[PATCH] D74340: [CodingStandards] Clarify C++ Standard Library usage

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 08:36:02 PST 2020


rjmccall added inline comments.


================
Comment at: llvm/docs/CodingStandards.rst:85
+
+When both C++ and the LLVM support libraries provide similar functionality, and
+there isn't a specific reason to favor the C++ implementation, it is generally
----------------
fhahn wrote:
> The programmer's manual has a section `Picking the Right Data Structure for a Task`  https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task
> 
> It goes into much more detail, but it might be good to link/unify both?
Ah, I'd forgotten about that section completely.  Yes, it should absolutely be linked here.  I don't think we want to merge the sections, though; what we've got now is a fine lead-in to a link like "For more information about LLVM's data structures and the tradeoffs they make, please consult [that section of the programmer's manual](https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task)."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74340/new/

https://reviews.llvm.org/D74340





More information about the llvm-commits mailing list