[PATCH] D74312: [DebugInfo]: Added preliminary support for DWARFv5 in llvm-dwp utility.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

In D74312#1869752 <https://reviews.llvm.org/D74312#1869752>, @dblaikie wrote:

> Please split this into smaller/more incremental patches - it should be possible to implement the new support for parsing DWARFv5 unit headers, signature, etc, without the new string header support. (you'd have to modify/hand-craft the dwo file assembly though, since LLVM's generated DWARFv5 will always use FORM_strx - but if you change the dwo to use FORM_str (direct strings, no indirection) it should mean you can make a small but valid test case without the need for strx support)


Hi Thanks for review!
Sounds good to me, will segregate this in 2 patches.

1. With DWARFv5 Info section parsing support.
2. With DWARFv String Offset parsing support.

Regarding, testing I'm considering adding the test cases to be written and tested with llvm-mc in this directory `llvm/test/tools/llvm-dwp/` . Didn't notice any debug-info related test case in `llvm/test/MC/X86` directory. Do you have any other suitable place in mind, Please share.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74312/new/

https://reviews.llvm.org/D74312