[PATCH] D74352: [SystemZ] Bugfix in emitSelect()

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa marked an inline comment as done.
jonpa added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:6890
+    if (NextMIIt->definesRegister(SystemZ::CC) ||
+        NextMIIt->usesCustomInsertionHook())
       break;
----------------
uweigand wrote:
> jonpa wrote:
> > uweigand wrote:
> > > Isn't this always true for select pseudos?  Why doesn't make the rest of this loop a no-op?
> > Oops! Sorry.
> Interesting that this didn't cause any test to fail ...  Don't we have tests that verify this loop does something?
We do and they were failing, it was just me who was too happy finding the cause of this problem and then forgetting to run the tests before submitting... 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74352/new/

https://reviews.llvm.org/D74352