[PATCH] D69701: [Utils] Allow "on-the-fly" argument changes for update_test_check scripts

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked an inline comment as done.
jdoerfert added a comment.

In D69701#1869559 <https://reviews.llvm.org/D69701#1869559>, @arichardson wrote:

> Looks good to me. Since this is in common.py, it would be nice to see it also applied to update_cc_test checks or update_llc_test_checks.


I agree but will leave that as a future improvement ;)



================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/basic.test:11
 # RUN: diff -u %t.ll %S/Inputs/basic.ll.funcsig.expected
-## Verify that running without the --function-signature flag removes the -SAME: lines:
+## Verify that running without the --function-signature flag does not removes the -SAME: lines:
 # RUN: %update_test_checks %t.ll
----------------
arichardson wrote:
> Maybe expand this comment to include "since the generated file will have --function-signature in an UTC_ARGS: comment" or similar
Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69701/new/

https://reviews.llvm.org/D69701