[PATCH] D74352: [SystemZ] Bugfix in emitSelect()

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

I guess it would be nicer if we could still handle this case somehow.

But anyway, for now bailing out is certainly preferable to aborting compilation.

LGTM.



================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:6890
+    if (NextMIIt->definesRegister(SystemZ::CC) ||
+        NextMIIt->usesCustomInsertionHook())
       break;
----------------
jonpa wrote:
> uweigand wrote:
> > Isn't this always true for select pseudos?  Why doesn't make the rest of this loop a no-op?
> Oops! Sorry.
Interesting that this didn't cause any test to fail ...  Don't we have tests that verify this loop does something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74352/new/

https://reviews.llvm.org/D74352