[PATCH] D74352: [SystemZ] Bugfix in emitSelect()

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 07:23:12 PST 2020


jonpa added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:6890
+    if (NextMIIt->definesRegister(SystemZ::CC) ||
+        NextMIIt->usesCustomInsertionHook())
       break;
----------------
uweigand wrote:
> Isn't this always true for select pseudos?  Why doesn't make the rest of this loop a no-op?
Oops! Sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74352/new/

https://reviews.llvm.org/D74352





More information about the llvm-commits mailing list