[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

Fady Ghanim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 07:05:06 PST 2020


fghanim added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:113
+  if (llvm::OpenMPIRBuilder *OMPBuilder = CGM.getOpenMPIRBuilder())
+    OMPBuilder->finalize();
 }
----------------
Does this mean that `finalize()` is being called twice everytime, here and `~OpenMPIRBuilder()`?
if yes, is there a reason why you want that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74372/new/

https://reviews.llvm.org/D74372





More information about the llvm-commits mailing list