[PATCH] D74198: [DebugInfo] Add support for DWARF64 into DWARFDebugAddr.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp:57
+    // Check that we can read the extended unit length field.
+    if (!Data.isValidOffsetForDataOfSize(*OffsetPtr, 8)) {
+      invalidateLength();
----------------
jhenderson wrote:
> IIRC, the `DataExtractor` class provides an optional second argument to its `get...` methods that can be used to specify an `Error` to pass any problems back in, including reading past the end. Would it make some sense to use that instead of the `isValid...` checks?
Can't say I like that because the resulting diagnostic messages might not be that informative as with the current approach.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74198/new/

https://reviews.llvm.org/D74198