[PATCH] D74394: [ARM][MVE] Tail-Predication: recognise (again) active lanes IR pattern

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM, if you can add a comment too.



================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:270-271
+             m_Add(m_Instruction(BroadcastSplat), m_Constant(Const))) &&
+      !match(TCP.Induction,
+             m_Or(m_Instruction(BroadcastSplat), m_Constant(Const))))
     return false;
----------------
I think if this was using an `or` it was because the BroadcastSplat value is mod Lanes. That is OK here because BroadcastSplat is IV which we know is a phi with 0 start and Lanes increment?

If so, can you add a comment that we know that it will be aligned, so an Or is equivalent to an Add?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74394/new/

https://reviews.llvm.org/D74394