[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

In D73086#1867934 <https://reviews.llvm.org/D73086#1867934>, @aprantl wrote:

> Currently the testing is very self-referential. Should we add a test in assembler (.s) in test/tools/llvm-dwarfdump that hardcodes a properly formatted macro section to make sure we don't add symmetric mistakes (where we implement the same mistake in both the generator and llvm-dwarfdump)?


Not sure what you meant here. The generation/emission patch emits/formats the contents of debug_macro correctly, for instance if you try to generate macro section using emission patch in clang. You can dump section contents of debug_macro section using objdump, It will dump contents entirely without any warnings/errors. As one more step for content verification, you use generated binary and can expand macros in LLDB. All these reaffirms that our emission implementation is correct!

Only reason, I've segregated this in 2 patches{emission/dumping} is for ease of review process. 
Once we get through this, I'm planning to merge back these 2 patches into single patch and land it as debug_macro section support in llvm and llvm-dwarfdump. Or in a mutually agreed way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086