[PATCH] D74367: [llvm-readelf] Print raw ELF note contents if we can't parse it

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 02:44:53 PST 2020


arichardson marked an inline comment as done.
arichardson added a comment.

In D74367#1868875 <https://reviews.llvm.org/D74367#1868875>, @jhenderson wrote:

> Is there a test case that shows we don't print the raw data when the decoding is known?


Not yet, but I've added a test case that would previously not print the contents for a GNU note of an unknown type.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5129
+      OS << "    <corrupt GNU_ABI_TAG>\n";
+      return false;
+    }
----------------
It seems like GNU readelf does not print the contents in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74367/new/

https://reviews.llvm.org/D74367





More information about the llvm-commits mailing list