[PATCH] D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D72197#1866461 <https://reviews.llvm.org/D72197#1866461>, @xiangzhangllvm wrote:

> Thanks for so detailed information, I am happy to push this thing go ahead.
>  But except the failed case, I feel let "protected symbol refer in same section" to directly calculate the symbol Vaule is better.
>  Does it will affected "symbol interposition"? I just know IFUN will use "symbol interposition".


It is just not very necessary. Protected symbols are rare. Such optimizations are not needed on the assembler side because the linker will optimize anyway (except GNU ld x86, but I don't think we need to work around such kind of regressions.)
These are serious GCC+BFD regressions that cannot be easily worked around in llvm-mc and I prefer not to work around them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72197/new/

https://reviews.llvm.org/D72197