[PATCH] D72696: [mlir][spirv] mlir-vulkan-runner

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

Nice work! Glad to see this coming together :)



================
Comment at: mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp:27
+#include "mlir/IR/StandardTypes.h"
+#include "mlir/Pass/Pass.h"
+
----------------
This pass does not seem to include anything that requires a Vulkan environment, it seems like it could be tested (and landed) independently, and not gated in CMake by the runner being enabled (which will help keeping this building in CI).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72696/new/

https://reviews.llvm.org/D72696