[PATCH] D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

I think the whole representation and syntax of loop.reduce / modeling reductions inside loop.for could be improved. Was this already discussed somewhere? If not, can we initiate one?



================
Comment at: mlir/include/mlir/Dialect/LoopOps/LoopOps.td:263
     ```mlir
        loop.parallel (%iv) = (%lb) to (%ub) step (%step) {
          %zero = constant 0.0 : f32
----------------
Is this missing a return value assignment for its result for clarity?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74174/new/

https://reviews.llvm.org/D74174