[PATCH] D74375: [ELF] Support INSERT [AFTER|BEFORE] for orphan sections
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 10 18:49:02 PST 2020
MaskRay marked an inline comment as done.
MaskRay added inline comments.
================
Comment at: lld/ELF/ScriptParser.cpp:548
+ if (atEOF() || !consume("INSERT")) {
+ // -no-rosegment is used to avoid placing read only non-executable sections
+ // in their own segment. We do the same if SECTIONS command is present in
----------------
In the future, we should stop enforcing --no-rosegment for hasSectionsCommand so that features can be more orthogonal. (I've mentioned this many times to Android/FreeBSD folks...)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74375/new/
https://reviews.llvm.org/D74375
More information about the llvm-commits
mailing list