[PATCH] D74196: [DebugInfo] Refine error messages in DWARFDebugAddr.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D74196#1868396 <https://reviews.llvm.org/D74196#1868396>, @ikudrin wrote:

> In D74196#1867749 <https://reviews.llvm.org/D74196#1867749>, @dblaikie wrote:
>
> > Pleas commit the rename from ".debug_addr table" to "address table" separately.
>
>
> Not sure I am following you. The purpose of this patch is to refine messages and change wordings here and there, so why this particular change should be separated?


Larger systemic changes like that are easier to review separately from more nuanced changes (this has more than just phrasing changes - and even if it did, I'd probably actually separate each phrasing change into its own commit - since they're not actually dependent on each other, but I'd make an exception for a mass renaming for consistency because it's easy enough to review as a batch (technically also easy to fail to spot that tests have appropriate updates when you're changing lots of diagnostics at the same time, but for such a mechanical change it's not so important to me that we check each one separately (wouldn't hurt, but I wouldn't insist on it)))


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74196/new/

https://reviews.llvm.org/D74196