[PATCH] D73486: [ms] [llvm-ml] Add support for attempted register parsing

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 13:21:57 PST 2020


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

lgtm

Please add tests for the error cases when llvm-ml is hooked up to this.

Come to think of it, maybe just putting`assert(false && "not implemented")` in the `tryParse()` functions for non-x86 is good enough, since we don't currently expect to call them. But up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73486/new/

https://reviews.llvm.org/D73486





More information about the llvm-commits mailing list