[PATCH] D73486: [ms] [llvm-ml] Add support for attempted register parsing

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 09:37:23 PST 2020


epastor marked 8 inline comments as done.
epastor added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1236
+        for (const AsmToken &T : Tokens) {
+          getLexer().UnLex(T);
+        }
----------------
thakis wrote:
> ditto
> 
> (also, this happens often enough that you might want to put it in a helper lambda?)
Helper lambda added


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73486/new/

https://reviews.llvm.org/D73486





More information about the llvm-commits mailing list