[llvm] 7b72c58 - DebugInfo: Avoid truncating addr_base to 32 bits
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 10 15:52:05 PST 2020
Author: David Blaikie
Date: 2020-02-10T15:50:52-08:00
New Revision: 7b72c5835cee5eda48a11e8a1b0d012de73ae103
URL: https://github.com/llvm/llvm-project/commit/7b72c5835cee5eda48a11e8a1b0d012de73ae103
DIFF: https://github.com/llvm/llvm-project/commit/7b72c5835cee5eda48a11e8a1b0d012de73ae103.diff
LOG: DebugInfo: Avoid truncating addr_base to 32 bits
I'm /guessing/ this isn't terribly testable without a very large input
file. Even generated from a more compact assembly file, it's probably
best not to generate a giant temporary test file - if I'm wrong about
that/anyone has good suggestions for testing, I'm all ears!
Based on post-commit review feedback from Igor Kudrin on
eed0242330926815d19dd0d54f393576bcffc762
Added:
Modified:
llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
index 27c2e6ccd620..1d313a3cca24 100644
--- a/llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
+++ b/llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
@@ -296,7 +296,7 @@ class DWARFUnit {
return StringOffsetSection;
}
- void setAddrOffsetSection(const DWARFSection *AOS, uint32_t Base) {
+ void setAddrOffsetSection(const DWARFSection *AOS, uint64_t Base) {
AddrOffsetSection = AOS;
AddrOffsetSectionBase = Base;
}
More information about the llvm-commits
mailing list