[PATCH] D73130: [mlir] Shared library support

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added inline comments.


================
Comment at: mlir/tools/mlir-shlib/CMakeLists.txt:40-41
+
+                 LINK_LIBS
+                 ${_DEPS})
+
----------------
I suspect that these libraries need to be added with whole_archive_link, to ensure that static initializers are called appropriately. (see the mlir-opt build rules and AddMLIR.cmake)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73130/new/

https://reviews.llvm.org/D73130