[PATCH] D74288: [MLIR][Affine] Add affine.parallel op

[Frank Laub via Phabricator via llvm-commits]

flaub added inline comments.


================
Comment at: mlir/include/mlir/Dialect/AffineOps/AffineOps.td:298
+
+      affine.parallel [%i, %j] = [0, 0] to [10, 10] step [1, 1] {
+        ...
----------------
jbruestle wrote:
> Why use square brackets rather than parens?  In general, tuples are usually parens.
This stems from the usage of `parseAffineMapOfSSAIds`, it apparently assumes square bracket delimiters.

@rriddle Would it break things if we allowed `parseAffineMapOfSSAIds` to take a delimiter so that we could group these ids in parens? I'm worried that this might cause ambiguity in the parser.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74288/new/

https://reviews.llvm.org/D74288