[PATCH] D73480: [VectorCombine] new IR transform pass for partial vector ops

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:34
+STATISTIC(NumVecCmp, "Number of vector compares formed");
+DEBUG_COUNTER(VecCombineCounter, "vector-combine-transform",
+              "Controls transformations in vector-combine pass");
----------------
spatel wrote:
> craig.topper wrote:
> > Is this counter used?
> Oops - no. Copy/pasted from existing code. Looks like other passes do something like:
>     if (!DebugCounter::shouldExecute(VecCombineCounter))
>       continue;
> 
> I've never used that myself, so I could either add that code or remove the counter. Let me know if there's a preference. Not sure how we test it?
Probably fine to drop it. I added the one to instcombine and I've only used it a couple times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73480/new/

https://reviews.llvm.org/D73480